Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit more relevant error message when failing to add source folder #1021

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Emit more relevant error message when failing to add source folder #1021

merged 3 commits into from
Nov 29, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Nov 25, 2021 •
edited
Loading

Fixes #1020

Replace this with a description of the changes your pull request makes.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@aeisenberg aeisenberg requested a review from a team as a code owner November 25, 2021 19:15
shati-patel
shati-patel approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! 🎉 Just a few suggestions on the wording 📝

extensions/ql-vscode/src/databases.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

@shati-patel Thanks for the clarifications!

@aeisenberg aeisenberg enabled auto-merge (squash) November 29, 2021 16:26
@aeisenberg aeisenberg merged commit b481441 into main Nov 29, 2021
@aeisenberg aeisenberg deleted the aeisenberg/source-archive-msg branch November 29, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding source files to workspace fails with "couldn't obtain file explorer uri for \<dbname\>"
2 participants
@aeisenberg @shati-patel