Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid showing the alert option in the drop down #1038

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Avoid showing the alert option in the drop down #1038

merged 2 commits into from
Dec 10, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Dec 7, 2021 •
edited
Loading

Only show it when there really is an alert table to see.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@aeisenberg
Avoid showing the alert option in the drop down
f2df595 
Only show it when there really is an alert table to see.
@aeisenberg aeisenberg requested a review from a team as a code owner December 7, 2021 02:04
shati-patel
shati-patel reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me 🎊

Could you add a changelog entry?

@aeisenberg aeisenberg linked an issue Dec 9, 2021 that may be closed by this pull request
Alerts option always shows in results view #1043
Closed
shati-patel
shati-patel approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aeisenberg aeisenberg merged commit 58f4a82 into main Dec 10, 2021
@aeisenberg aeisenberg deleted the aeisenberg/alert-table-fix branch December 10, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alerts option always shows in results view
2 participants
@aeisenberg @shati-patel