Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results view: Don't reopen webview if it's already visible #1070

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Jan 6, 2022

A user reported a bug where the results view is opened in the active editor, even if the results view is already visible in a different column:

🖱️ Expand for example GIF

34F3083B-05A6-46EF-8954-6D74615756E0

This PR fixes that behaviour. I.e. when there's already a results view visible (not necessarily active), we display the results in that panel.

Notes

A slight weirdness we could still find is that if the results view is open in a tab somewhere, but not visible, it can still move to a different place. I don't think this is a problem, but I can open an issue if it is!

🖱 Expand for details

In this case, the results view is open on the right, but it isn't currently visible. Since the right-hand side is the active editor, the new results open on the left. (So the results view moves column.)

8003AFBE-3E96-4AB6-9083-33C1FB4D622A

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • [n/a] Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] If this pull request makes user-facing changes that require documentation changes, the ready-for-doc-review label has been added to this pull request or the corresponding issue.

@shati-patel shati-patel marked this pull request as ready for review January 6, 2022 14:17
@shati-patel shati-patel requested a review from a team as a code owner January 6, 2022 14:17
@shati-patel shati-patel merged commit fc51b33 into github:main Jan 6, 2022
@shati-patel shati-patel deleted the shati-patel/results-view branch January 6, 2022 19:34
@Metabori
This comment was marked as off-topic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants