Results view: Don't reopen webview if it's already visible #1070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported a bug where the results view is opened in the active editor, even if the results view is already visible in a different column:
🖱️ Expand for example GIF
This PR fixes that behaviour. I.e. when there's already a results view visible (not necessarily active), we display the results in that panel.
Notes
A slight weirdness we could still find is that if the results view is open in a tab somewhere, but not visible, it can still move to a different place. I don't think this is a problem, but I can open an issue if it is!
🖱 Expand for details
In this case, the results view is open on the right, but it isn't currently visible. Since the right-hand side is the active editor, the new results open on the left. (So the results view moves column.)
Checklist
ready-for-doc-review
label has been added to this pull request or the corresponding issue.