Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid file comparison for changing ast viewer location #1230

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Fix invalid file comparison for changing ast viewer location #1230

merged 2 commits into from
Mar 25, 2022

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Mar 24, 2022 •
edited
Loading

This fixes a bug where the ast viewer was not updating its source
location when a user clicks on different parts of a file.

The problem was that the file name of the AST viewer was being stored as
a base name, which was getting compared with the full URI string of the
current file.

This fixes the comparison to ensure that the full URI strings are always
being compared.

Fixes #1224.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg
Fix invalid file comparison for changing ast viewer location
0fa91f3 
This fixes a bug where the ast viewer was not updating its source
location when a user clicks on different parts of a file.

The problem was that the file name of the AST viewer was being stored as
a base name, which was getting compared with the full URI string of the
current file.

This fixes the comparison to ensure that the full URI strings are always
being compared.
@aeisenberg aeisenberg requested a review from a team as a code owner March 24, 2022 19:37
shati-patel
shati-patel approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks sensible (and works for me locally) 😄

@aeisenberg aeisenberg merged commit 3e3e12a into main Mar 25, 2022
@aeisenberg aeisenberg deleted the aeisenberg/astviewer-uri branch March 25, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AST viewer does not highlight corresponding node when clicking in the source file
2 participants
@aeisenberg @shati-patel