Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke codeql pack install after adding a quick query #1411

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jun 28, 2022

This ensures the pack lock file is in place after the quick query is generated.

Fixes a bug where quick queries cannot be compiled if the core libraries are not in the workspace.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg aeisenberg requested a review from a team as a code owner June 28, 2022 18:35
@aeisenberg aeisenberg force-pushed the aeisenberg/quick-query-fix branch from 8d0ebe0 to 69ba377 Compare June 28, 2022 19:27
This ensures the pack lock file is in place after the quick query is
generated.
@aeisenberg aeisenberg force-pushed the aeisenberg/quick-query-fix branch from 69ba377 to 369fa95 Compare June 28, 2022 20:20
@edoardopirovano edoardopirovano merged commit 22873a2 into main Jun 29, 2022
@edoardopirovano edoardopirovano deleted the aeisenberg/quick-query-fix branch June 29, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants