Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate download from LGTM by hiding it behind canary flag #1467

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Deprecate download from LGTM by hiding it behind canary flag #1467

merged 4 commits into from
Sep 16, 2022

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Aug 23, 2022 •
edited
Loading

This will hide the download from LGTM functionality behind the canary config setting, effectively removing it for all normal users.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 requested a review from a team August 23, 2022 14:07
@koesie10 koesie10 requested a review from a team as a code owner August 23, 2022 14:07
charisk
charisk approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertbrignull
Copy link
Contributor

PR looks good but a note we don't want to merge this just yet. Need to get a few other things done first.

@robertbrignull
Copy link
Contributor

Should be good to merge now. We have the documentation and changelog post ready.

@koesie10 koesie10 merged commit 10eb355 into main Sep 16, 2022
@koesie10 koesie10 deleted the koesie10/deprecate-lgtm-download branch September 16, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koesie10 @robertbrignull @charisk