Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart CLI server too when restarting query server #1487

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

edoardopirovano
Copy link
Contributor

Closes #1486

@aschackmull encountered a bug where after he'd rebuilt his CodeQL dist, he did Restart query server so was running with a new query server, however was still using an old CLI because the CLI server had not been restarted. This led to a bug because the old CLI did not understand the evaluator logs produced by the new query server. The solution, I think, is for the extension to also restart the CLI server when it restarts the query server in order to ensure they are the same version.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@edoardopirovano edoardopirovano added bug Something isn't working Complexity: Low A good task for newcomers to learn, or experienced team members to complete quickly. labels Aug 31, 2022
@edoardopirovano edoardopirovano requested a review from a team as a code owner August 31, 2022 09:59
@edoardopirovano edoardopirovano merged commit 84bd029 into main Aug 31, 2022
@edoardopirovano edoardopirovano deleted the edoardo/restart-cli-server branch August 31, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Complexity: Low A good task for newcomers to learn, or experienced team members to complete quickly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension should restart the CLI server whenever it restarts the query server
2 participants