Restart CLI server too when restarting query server #1487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1486
@aschackmull encountered a bug where after he'd rebuilt his CodeQL dist, he did Restart query server so was running with a new query server, however was still using an old CLI because the CLI server had not been restarted. This led to a bug because the old CLI did not understand the evaluator logs produced by the new query server. The solution, I think, is for the extension to also restart the CLI server when it restarts the query server in order to ensure they are the same version.
Checklist
ready-for-doc-review
label there.