Don't display destructive upgrades any more. #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardopirovano
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Seems reasonable. I've done a quick search of our documentation and found no references to this. Perhaps there's some other documentation my search missed, though.
|
Do we want a change log entry for this. It is certainly user visible? I can write one if we do. |
|
A brief change note sounds good. Mention the command has been removed from the context menu and is no longer necessary. |
|
I have written a change note. |
alexet
force-pushed
the
alexet/no-display-destructive-upgrades
branch
from
66d1b8f to
5bc162e
Compare
adityasharad
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most users don't want to destructively upgrade their database any more. This hides the option from the right click menu. It is still visible in the command picker for those users who actually want to do that.
Checklist
ready-for-doc-reviewlabel there.