Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization error #1605

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix deserialization error #1605

merged 2 commits into from
Oct 14, 2022

Conversation

aeisenberg
Copy link
Contributor

We added a successful property to serialized local queries. But, this property does not exist on older serialized queries. This change ensures older queries get a successful property when deserialized.

Clearly, our (de-)serialization tests are not sufficient. After this change goes in, I'll add some new tests for it. I've tried this out locally and this change is working.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

We added a `successful` property to serialized local queries. But, this
property does not exist on older serialized queries. This change ensures
older queries get a `successful` property when deserialized.
@aeisenberg aeisenberg requested a review from a team as a code owner October 14, 2022 14:40
@aeisenberg aeisenberg requested review from alexet and charisk October 14, 2022 14:43
@aeisenberg aeisenberg enabled auto-merge October 14, 2022 15:19
@shati-patel
Copy link
Contributor

Thanks @aeisenberg! ❤️ That was a more damaging typo fix than I'd realised 😅

@aeisenberg
Copy link
Contributor Author

There were actually two issues here. Not just the typo.

@aeisenberg aeisenberg merged commit 0354b1c into main Oct 14, 2022
@aeisenberg aeisenberg deleted the aeisenberg/fix-missing-success branch October 14, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants