Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsupported version constraints #1788

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Remove unsupported version constraints #1788

merged 1 commit into from
Jan 24, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Nov 24, 2022 •
edited
Loading

This removes all CodeQL CLI version constraints for unsupported CLI versions (< 2.7.6). The oldest supported CLI version is 2.7.6 since GHES 3.4 recommends using CodeQL CLI 2.7.6.

I've also removed a constraint on version 2.7.1, but I'm not sure if we still support all 2.7.x versions.

Please double check that I made the correct transformations in call-sites, especially with regards to if conditions being true/false.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review November 24, 2022 15:49
@koesie10 koesie10 requested review from a team as code owners November 24, 2022 15:49
@shati-patel shati-patel mentioned this pull request Jan 20, 2023
Merged
@koesie10
Remove unsupported version constraints
140d369 
This removes all CodeQL CLI version constraints for unsupported CLI
versions (< 2.7.6). The oldest supported CLI version is 2.7.6 since GHES
3.3 recommends using CodeQL CLI 2.7.6.
@koesie10 koesie10 force-pushed the koesie10/remove-unsupported-version-constraints branch from ef6686c to 140d369 Compare January 23, 2023 13:13
@koesie10
Copy link
Member Author

@aeisenberg Would you be able to confirm that we're not supporting the older 2.7 minor versions anymore?

@aeisenberg
Copy link
Contributor

Yes. That's exactly right. 2.7.6 is the earliest version we need to support.

aeisenberg
aeisenberg approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's great to be deleting all this old code.

One thing to consider is maybe we want to have a check during startup in extension.ts where we throw an error if the CLI version is < 2.7.6. Doing this or not should not block this PR.

@koesie10 koesie10 merged commit f7a9830 into main Jan 24, 2023
@koesie10 koesie10 deleted the koesie10/remove-unsupported-version-constraints branch January 24, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenatanasoiu elenatanasoiu elenatanasoiu approved these changes

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koesie10 @aeisenberg @elenatanasoiu