Don't rate limit if no CLI is installed #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps to avoid a specific case where your managed CodeQL CLI gets uninstalled (not sure how, but it can happen during extension upgrades) and then the extension refuses to install a new one because it tried that within the last 24 hours. This PR makes it so that if no CLI is installed then it'll always try installing one.
I'm able to reproduce the bug easily by adding a simple "removeDatabase" command. I didn't include it in this screenshot but the extension fails to load and you're totally stuck.
With this PR it always installs the CLI if it couldn't find one.
Checklist
ready-for-doc-reviewlabel there.