Remove query history title actions #2350
Conversation
| @@ -176,9 +176,7 @@ export type QueryHistoryCommands = { | |||
| "codeQLQueryHistory.sortByCount": () => Promise<void>; | |||
|
|
|||
| // Commands in the context menu or in the hover menu | |||
| "codeQLQueryHistory.openQueryTitleMenu": TreeViewTitleMultiSelectionCommandFunction<QueryHistoryInfo>; | |||
There was a problem hiding this comment.
You should be able to remove the TreeViewTitleMultiSelectionCommandFunction type now. The only usage should be for codeQLQueryHistory.itemClicked and that can now have its type changed to TreeViewContextMultiSelectionCommandFunction.
There was a problem hiding this comment.
Thanks, I should've checked this.
|
Thanks for tidying this up. Would be great to update the CHANGELOG too. Also, do we need to update any docs? |
norascheuch
force-pushed
the
nora/remove-query-history-title-bar-actions
branch
from
d3bf91f to
2be0c16
Compare
extensions/ql-vscode/CHANGELOG.md
Outdated
| @@ -3,6 +3,7 @@ | |||
| ## [UNRELEASED] | |||
|
|
|||
| - Add new configuration option to allow downloading databases from http, non-secure servers. [#2332](https://github.com/github/vscode-codeql/pull/2332) | |||
| - Remove title actions from the query history panel that depended on history items being selected. | |||
There was a problem hiding this comment.
Do you mind adding a PR link to match the pattern we use for changelog entries? See the above entry for specifics
There was a problem hiding this comment.
Done! Regarding the Docs: we don't seem to mention the titel actions in the docs (https://codeql.github.com/docs/codeql-for-visual-studio-code/analyzing-your-projects/) so I think we don't need to update them.
|
LGTM once the changelog PR link is added |
norascheuch
force-pushed
the
nora/remove-query-history-title-bar-actions
branch
from
2299b90 to
82c8068
Compare
Docs is an interesting question. I've looked through https://codeql.github.com/docs/codeql-for-visual-studio-code and I can't see any mention of this behaviour, so I think we're good. Even the screenshot at https://codeql.github.com/docs/codeql-for-visual-studio-code/analyzing-your-projects/#viewing-previous-queries doesn't include the title bar actions. |
Removes the title actions of the query history panel, because newest telemetry show that they are not used by users. Additionally, to unify UI behaviour, we remove them so that we don't have any title actions dependent on a specific selection.
Checklist
ready-for-doc-reviewlabel there.