Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure full stack traces are included in log messages #2425

Merged
merged 3 commits into from
May 17, 2023
Merged

Ensure full stack traces are included in log messages #2425

merged 3 commits into from
May 17, 2023

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented May 16, 2023 •
edited
Loading

Pass in the fullMessage to internalShowAndLog so that stack traces aren't truncated.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg
Ensure full stack traces are included in log messages
276e2cf 
Pass in the `fullMessage` to `internalShowAndLog` so that stack traces
aren't truncated.
@aeisenberg aeisenberg requested a review from a team as a code owner May 16, 2023 21:49
@aeisenberg aeisenberg requested a review from robertbrignull May 16, 2023 21:51
@aeisenberg aeisenberg enabled auto-merge May 17, 2023 15:08
@aeisenberg aeisenberg merged commit 3ebd13d into main May 17, 2023
@aeisenberg aeisenberg deleted the aeisenberg/truncated-log-msg branch May 17, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @robertbrignull