Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code lens for "Open referenced file" #2704

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Aug 14, 2023

Makes the "Open referenced file" command more discoverable by adding a code lens:
image

Click that prompt to jump to the referenced QL file 😎 See internal issue for more details! 🔍

Notes:

  • I put this in the local-queries folder, which seemed reasonable 😅 Happy to be pointed to a more suitable location!
  • I couldn't think of a useful way to test this, since it just calls out to the existing codeQL.openReferencedFile command...

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review August 14, 2023 11:33
@shati-patel shati-patel requested a review from a team as a code owner August 14, 2023 11:33
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to wait for a review from @github/codeql-vscode-reviewers, but the code looks good to me and I tried testing it and the codelens worked and was intuitive.

@shati-patel shati-patel merged commit 2569f63 into main Aug 14, 2023
@shati-patel shati-patel deleted the shati-patel/open-ref-code-lens branch August 14, 2023 14:26
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea. Thanks for implementing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants