Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group extension settings in the VS Code UI #2706

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Aug 14, 2023

Grouped the extension settings into categories, so you can more easily jump to the right section in the sidebar ⚙
image

I haven't changed any of the settings, and I've just grouped them roughly based on their name (e.g. codeQL.runningQueries.memory under "Running queries", codeQL.cli.executablePath under "CLI" etc). Happy for alternative suggestions for naming and ordering!

See internal linked issue for more details 👀

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel force-pushed the shati-patel/group-settings branch from 25f42de to 595f939 Compare August 14, 2023 14:30
@shati-patel shati-patel marked this pull request as ready for review August 14, 2023 14:31
@shati-patel shati-patel requested a review from a team as a code owner August 14, 2023 14:31
@shati-patel shati-patel marked this pull request as draft August 14, 2023 15:03
@shati-patel
Copy link
Contributor Author

Ok, that broke the config somehow 😅 Will go and figure out what's up with the tests!

@shati-patel shati-patel force-pushed the shati-patel/group-settings branch from 595f939 to 86c4616 Compare August 15, 2023 13:34
@shati-patel
Copy link
Contributor Author

Ok, that broke the config somehow 😅 Will go and figure out what's up with the tests!

Turns out our test config file read the property keys from the package.json, expecting them to be in a single object under contributes.configuration instead of an array of objects. Thanks to @robertbrignull for helping find and fix that 🙇🏽‍♀️

@shati-patel shati-patel marked this pull request as ready for review August 15, 2023 13:45
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shati-patel shati-patel merged commit 2db0ca8 into main Aug 17, 2023
@shati-patel shati-patel deleted the shati-patel/group-settings branch August 17, 2023 15:48
@shati-patel shati-patel mentioned this pull request Aug 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants