Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right align and format raw result numbers #2864

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Right align and format raw result numbers #2864

merged 1 commit into from
Sep 27, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Sep 26, 2023 •
edited
Loading

This changes the formatting for both the local raw results table and the variant analysis raw results table to right align and format numbers.

Screenshot 2023-09-26 at 15 12 33

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/right-align-format-numbers branch from e961c90 to 1e8cd2e Compare September 26, 2023 13:20
@koesie10 koesie10 marked this pull request as ready for review September 26, 2023 13:41
@koesie10 koesie10 requested review from a team as code owners September 26, 2023 13:41
@koesie10
Right align and format raw result numbers
e475036 
This changes the formatting for both the local raw results table and the
variant analysis raw results table to right align and format numbers.
@koesie10 koesie10 force-pushed the koesie10/right-align-format-numbers branch from 1e8cd2e to e475036 Compare September 26, 2023 14:18
charisk
charisk approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@koesie10 koesie10 merged commit 7501f9b into main Sep 27, 2023
@koesie10 koesie10 deleted the koesie10/right-align-format-numbers branch September 27, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk