Upgrade MSW #2877
Merged
Upgrade MSW #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like Node's native `fetch` implementation isn't quite working right with Octokit and MSW. This switches to using `node-fetch` like we're already doing for all other requests (e.g. downloading databases).
koesie10
force-pushed
the
robertbrignull/upgrade_msw
branch
from
cec6123 to
9b10a09
Compare
koesie10
force-pushed
the
robertbrignull/upgrade_msw
branch
from
56b4243 to
40b79f2
Compare
robertbrignull
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
LGTM
I've tested it with normal VS Code and also insiders, and with the API server disabled, enabled, and with a scenario loaded. Everything worked perfectly for me.
Since #2854 has been included in the most recent release, I believe that means this should be good to merge now.
koesie10
added a commit
that referenced
this pull request
Jan 3, 2024
There were still references to a pinned version of VS Code used in the integration tests, but this was resolved in #2877.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades MSW to the
@nexttag (currently0.0.0-fetch.rc-20) to support Node.js 18.This stops all unit and integration tests from using Node.js 16. Therefore, this also bumps
engines.vcodeto1.82.0. This is in line with #2854 and our process for upgrading the minimum VS Code version.Checklist
ready-for-doc-reviewlabel there.