Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use saveBeforeStart setting when running a variant analysis #2950

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Use saveBeforeStart setting when running a variant analysis #2950

merged 2 commits into from
Oct 11, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Oct 11, 2023 •
edited
Loading

This will respect the user's saveBeforeStart setting when running a variant analysis. This re-uses the existing saveBeforeStart function that is used when running local queries. The default behavior if the setting is not set is to save all open named files.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10
Use saveBeforeStart setting when running a variant analysis
0bdd441 
This will respect the user's `saveBeforeStart` setting when running a
variant analysis. This re-uses the existing `saveBeforeStart` function
that is used when running local queries. The default behavior if the
setting is not set is to save all open named files.
@koesie10
Update CHANGELOG
1121852
@koesie10 koesie10 marked this pull request as ready for review October 11, 2023 11:55
@koesie10 koesie10 requested review from a team as code owners October 11, 2023 11:55
charisk
charisk approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koesie10 koesie10 merged commit 918362f into main Oct 11, 2023
25 checks passed
@koesie10 koesie10 deleted the koesie10/variant-analysis-save-before-start branch October 11, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk