Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the logFileLocation is set #2984

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Ensure the logFileLocation is set #2984

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc0e850
Ensure the `logFileLocation` is set
aeisenberg Oct 16, 2023
4ad3d96
Add change note
aeisenberg Oct 18, 2023
2e2051a
Merge branch 'main' into aeisenberg/fix-log-path
aeisenberg Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion extensions/ql-vscode/src/query-results.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
* The legacy result. This is only set when loading from the query history.
*/
public readonly result: legacyMessages.EvaluationResult,
public readonly logFileLocation: string | undefined,

Check warning

Code scanning / CodeQL

Useless assignment to property Warning

This write to property 'logFileLocation' is useless, since
another property write
Loading
always overrides it.
public readonly successful: boolean | undefined,
public readonly message: string | undefined,
/**
Expand All @@ -74,7 +74,10 @@
* Map from result set name to SortedResultSetInfo.
*/
public sortedResultsInfo: Record<string, SortedResultSetInfo> = {},
) {}
) {
// The log path is only set when loading from the query history.
this.logFileLocation = logFileLocation ?? this.query.logPath;
}

setResultCount(value: number) {
this.resultCount = value;
Expand Down
Loading