Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty message with empty SARIF path #3018

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix empty message with empty SARIF path #3018

merged 2 commits into from
Oct 26, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Oct 25, 2023 •
edited
Loading

This fixes an empty message when the SARIF artifact location is file://. I've also added it to a story to see it locally without running a query.

Before:

Screenshot 2023-10-25 at 15 23 29

After:

Screenshot 2023-10-25 at 15 24 02

Query that shows this problem: cpp/ql/src/Security/CWE/CWE-079/CgiXss.ql with kirxkirx/vast.

Closes #1357

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review October 25, 2023 14:18
@koesie10 koesie10 requested a review from a team as a code owner October 25, 2023 14:18
charisk
charisk approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the story.

@charisk
Copy link
Contributor

charisk commented Oct 26, 2023

Shall we add a CHANGELOG entry and merge for today's release?

@koesie10 koesie10 enabled auto-merge October 26, 2023 08:49
@koesie10 koesie10 merged commit 40a77df into main Oct 26, 2023
14 checks passed
@koesie10 koesie10 deleted the koesie10/fix-empty-location branch October 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path viewer shows empty line for file:// locations
2 participants
@koesie10 @charisk