Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort databases by name if their languages are the same #3055

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Sort databases by name if their languages are the same #3055

merged 1 commit into from
Nov 6, 2023

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Nov 6, 2023 •
edited
Loading

When databases in the DB panel have the same language, let's sort them by name within each language.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review November 6, 2023 15:18
@shati-patel shati-patel requested review from a team as code owners November 6, 2023 15:18
robertbrignull
robertbrignull approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📈 📉

@shati-patel shati-patel merged commit 429f9a1 into main Nov 6, 2023
14 checks passed
@shati-patel shati-patel deleted the shati-patel/db-sort branch November 6, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shati-patel @robertbrignull