Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage use of "Quick query" in single-folder workspaces #3082

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Nov 21, 2023

The "Quick query" command creates a new workspace folder, which doesn't work well for users in single-folder workspaces. This PR adds a prompt for those people to encourage them to use the new "Create query" command instead:

image

See internal linked issue for more details.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.
    • N/A: No docs change needed

@shati-patel shati-patel force-pushed the shati-patel/quick-query branch from 6fce796 to eb15a90 Compare November 21, 2023 14:15
@shati-patel shati-patel marked this pull request as ready for review November 21, 2023 14:36
@shati-patel shati-patel requested a review from a team as a code owner November 21, 2023 14:36
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in general, just a quick question around the new command.

extensions/ql-vscode/package.json Outdated Show resolved Hide resolved
@shati-patel shati-patel merged commit 424e8d3 into main Nov 23, 2023
14 checks passed
@shati-patel shati-patel deleted the shati-patel/quick-query branch November 23, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants