Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading message for compare view #3107

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix loading message for compare view #3107

merged 2 commits into from
Dec 6, 2023

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Dec 6, 2023

The loading message for the compare view was never shown because the comparison was never undefined/null. This changes the comparison to be null on load to make sure that we explicitly handle this case rather than relying on an empty comparison message. This helps when there is a large number of results and loading them takes a while.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review December 6, 2023 10:14
@koesie10 koesie10 requested a review from a team as a code owner December 6, 2023 10:14
charisk
charisk approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we need to update the CHANGELOG?

@koesie10
Copy link
Member Author

koesie10 commented Dec 6, 2023

LGTM! Do we need to update the CHANGELOG?

Good idea, I'll add this fix to the CHANGELOG.

@koesie10 koesie10 enabled auto-merge December 6, 2023 10:19
@koesie10 koesie10 merged commit 4a32170 into main Dec 6, 2023
14 checks passed
@koesie10 koesie10 deleted the koesie10/fix-compare-loading-message branch December 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk