Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flags for release v1.11.0 #3128

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Dec 12, 2023

This removes the "feature flags" for the CodeQL method modeling and multiple models per method. Both already had their actual feature flags removed but were still behind canary. This removes that check and removes old code that is now unused.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review December 12, 2023 14:26
@koesie10 koesie10 requested review from a team as code owners December 12, 2023 14:26
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes and deleted code looks good to me.

I haven't tried running it but I trust you have tested it, and also we'll be doing some testing before the release.

@koesie10 koesie10 merged commit a2f3f5f into main Dec 13, 2023
25 checks passed
@koesie10 koesie10 deleted the koesie10/feature-flags-1.11.0 branch December 13, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants