Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress reporting for unzipping files #3157

Merged
merged 10 commits into from
Dec 21, 2023
Merged

Add progress reporting for unzipping files #3157

merged 10 commits into from
Dec 21, 2023

Conversation

koesie10
Copy link
Member

This adds progress reporting for unzipping files in two places:

  • When extracting the CodeQL distribution in ensureCli.ts

Screenshot 2023-12-19 at 16 55 05

  • When extracting the CodeQL distribution for users
Screen.Recording.2023-12-19.at.16.55.49.mov

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Base automatically changed from koesie10/yauzl-concurrent to main December 20, 2023 09:23
@koesie10 koesie10 force-pushed the koesie10/yauzl-progress branch from 024ff88 to 2267e9d Compare December 20, 2023 09:33
@koesie10 koesie10 marked this pull request as ready for review December 20, 2023 09:50
@koesie10 koesie10 requested a review from a team as a code owner December 20, 2023 09:50
charisk
charisk approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

extensions/ql-vscode/src/common/unzip.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/src/common/unzip.ts Show resolved Hide resolved
extensions/ql-vscode/src/common/vscode/progress.ts Outdated Show resolved Hide resolved
@koesie10 koesie10 merged commit a8dd368 into main Dec 21, 2023
28 checks passed
@koesie10 koesie10 deleted the koesie10/yauzl-progress branch December 21, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charisk charisk charisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @charisk