Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show notification after local query cancellation #3489

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Don't show notification after local query cancellation #3489

merged 2 commits into from
Mar 18, 2024

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Mar 18, 2024

Update error handling of running a local query to check if cancellation was requested by the user, and avoid showing a notification when that happens.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner March 18, 2024 14:44
shati-patel
shati-patel approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@charisk charisk merged commit 3f817b3 into main Mar 18, 2024
15 checks passed
@charisk charisk deleted the charisk/cancel-local-query-notification branch March 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @shati-patel