Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported sink and source kinds in the model editor #3511

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Update supported sink and source kinds in the model editor #3511

merged 3 commits into from
Mar 26, 2024

Conversation

koesie10
Copy link
Member

This updates the supported sink and source kinds that are shown in the model editor to the latest CodeQL valid source/sink kinds. It splits out Java and C# since these will now have different source/sink kinds.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review March 26, 2024 11:53
@koesie10 koesie10 requested review from a team as code owners March 26, 2024 11:53
shati-patel
shati-patel approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for linking to the github/codeql sources too 🙌🏽

@koesie10 koesie10 merged commit 8de8545 into main Mar 26, 2024
25 of 26 checks passed
@koesie10 koesie10 deleted the koesie10/update-kinds branch March 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koesie10 @shati-patel