Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report progress for post-evaluation actions #3622

Merged
merged 2 commits into from
May 28, 2024

Conversation

nickrolfe
Copy link
Contributor

Generating and parsing log summaries can be quite slow, so we should update the progress window with messages about what's being worked on.

I don't really know TypeScript, so there may be a nicer way of achieving what I've done here. 🤷

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@nickrolfe nickrolfe requested a review from a team as a code owner May 23, 2024 13:42
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM. Can you add a changelog entry for this?

I wonder (and this is unrelated to your change) if we can summarize the evaluator logs in the background after showing the results for the query. There's no reason why the results view should be blocked while we're summarizing evaluator logs.

nickrolfe added 2 commits May 28, 2024 11:05
Generating and parsing log summaries can be quite slow, so we should update the progress window with messages about what's being worked on.
@nickrolfe nickrolfe force-pushed the nickrolfe/eval-log-progress branch from c82f406 to b43b1d4 Compare May 28, 2024 11:06
@nickrolfe nickrolfe merged commit 83df05e into main May 28, 2024
15 checks passed
@nickrolfe nickrolfe deleted the nickrolfe/eval-log-progress branch May 28, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants