Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing to VS Code Marketplace #3882

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

koesie10
Copy link
Member

This may fix publishing to the VS Code Marketplace, which is currently broken because npx isn't included in the azure/cli Docker image. This is based on the publishing steps of a Microsoft VS Code extension: https://github.com/microsoft/vscode-azureapicenter/blob/13175ef0638b56fa1e605bd4750ec77b1ba5b72d/.github/workflows/publish.yml#L57-L71

I don't think we can test this without creating another release.

@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 09:27
@koesie10 koesie10 requested a review from a team as a code owner December 20, 2024 09:27

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@aeisenberg
Copy link
Contributor

I'll try to republish later today.

@aeisenberg aeisenberg merged commit a86775f into main Dec 20, 2024
16 checks passed
@aeisenberg aeisenberg deleted the koesie10/fix-azure-publish branch December 20, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants