Open editor containing query location in non-preview mode #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/non-preview-editor
branch
from
1f5334d to
cb30009
Compare
aeisenberg
added
the
Complexity: Low
aeisenberg
force-pushed
the
aeisenberg/non-preview-editor
branch
from
cb30009 to
5a3142a
Compare
adityasharad
requested changes
Nov 4, 2020
extensions/ql-vscode/CHANGELOG.md
Outdated
| @@ -21,6 +22,7 @@ | |||
| - Add a `View DIL` command on query history items. This opens a text editor containing the Datalog Intermediary Language representation of the compiled query. | |||
| - Remove feature flag for the AST Viewer. For more information on how to use the AST Viewer, [see the documentation](https://help.semmle.com/codeql/codeql-for-vscode/procedures/exploring-the-structure-of-your-source-code.html). | |||
| - The `codeQL.runningTests.numberOfThreads` setting is now used correctly when running tests. | |||
| - Add the `codeQL.ui.openInPreviewEditor` config option. This option allows users to open query results in non-preview editors (by un-checking this option). Doing so will make navigation between results files easier, but may also contribute to a proliferation of open editors. | |||
There was a problem hiding this comment.
No longer necessary now you're making it unconditional?
There was a problem hiding this comment.
Yep. Let me delete
extensions/ql-vscode/package.json
Outdated
| @@ -110,6 +110,11 @@ | |||
| "type": "object", | |||
| "title": "CodeQL", | |||
| "properties": { | |||
| "codeQL.ui.openInPreviewEditor": { | |||
There was a problem hiding this comment.
Similarly, no longer necessary?
| : await Window.showTextDocument(doc, ViewColumn.One); | ||
| : await Window.showTextDocument( | ||
| doc, { | ||
| preview: true, |
There was a problem hiding this comment.
preview: false? Also maybe comment here about why.
aeisenberg
force-pushed
the
aeisenberg/non-preview-editor
branch
from
e79d68e to
b77b676
Compare
adityasharad
approved these changes
Nov 5, 2020
aeisenberg
force-pushed
the
aeisenberg/non-preview-editor
branch
from
b77b676 to
f82a2ce
Compare
|
Could you provide this with an option? I think this option is really useful for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new config option to control this behavior. If this behavior isgenerally desirable, we will remove the option and avoid using preview
editors for all users.
Not going with a config setting as I don't feel like we should be cluttering up the settings page.
This change partially mitigates the limitations with how vscode handles editors backed by custom uri providers.
See #500 (comment) for an explanation of what this does and why we should do it.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.