Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable codeql test commands from the command palette #667

Merged

Conversation

aeisenberg
Copy link
Contributor

These commands are not applicable from the global context. They require
an argument to be passed in. So, they should be hidden in the command
palette.

Fixes #658.

Checklist

  • [n/a] CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] @github/docs-content-dsp has been cc'd in all issues for UI or other user-facing changes made by this pull request.

These commands are not applicable from the global context. They require
an argument to be passed in. So, they should be hidden in the command
palette.
@aeisenberg aeisenberg force-pushed the aeisenberg/disable-test-commands branch from b91c150 to ee5d45e Compare November 3, 2020 22:21
@aeisenberg aeisenberg added the Complexity: Low A good task for newcomers to learn, or experienced team members to complete quickly. label Nov 3, 2020
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest a query, but it looks like you've modelled the pattern in the unit tests instead.

@aeisenberg aeisenberg merged commit b2b1021 into github:main Nov 3, 2020
@aeisenberg aeisenberg deleted the aeisenberg/disable-test-commands branch November 24, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low A good task for newcomers to learn, or experienced team members to complete quickly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeQL: Show Test Output Differences fails from the Command Palette
2 participants