Add descriptive text and a link at top of query results #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The descriptive text is the same as the label in the query history view. The link opens the file that ran the query.
aeisenberg
force-pushed
the
aeisenberg/query-description
branch
from
21d007d to
b8911a5
Compare
adityasharad
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
A nice usability improvement.
In the new year I would like to get @donokuda's suggestions on the entire results panel, to see whether we can make the visual presentation more refined. But no need to hold up this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The descriptive text is the same as the label in the query history view. The link opens the file that ran the query.
Here is a screenshot of a wide window:
And here is a narrow window:
Fixes #634.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.