Change text of modal dialog #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/modal
branch
from
55e919c to
cae375a
Compare
adityasharad
requested changes
Jan 30, 2021
| @@ -165,8 +165,9 @@ export class TelemetryListener extends ConfigListener { | |||
| if (GLOBAL_ENABLE_TELEMETRY.getValue()) { | |||
| // Extension won't start until this completes. | |||
| result = await showBinaryChoiceDialog( | |||
| 'Do we have your permission to collect usage data and metrics to help us improve CodeQL for VSCode? See [TELEMETRY.md](https://github.com/github/vscode-codeql/blob/main/TELEMETRY.md) for details of what we collect and how we use it.', | |||
| 'CodeQL Extension: Do we have your permission to collect usage data and metrics to help us improve CodeQL for VSCode? See https://github.com/github/vscode-codeql/blob/main/TELEMETRY.md for details of what we collect and how we use it.', | |||
There was a problem hiding this comment.
Either this needs to be blob/main/extensions/ql-vscode/TELEMETRY.md or we need to move the md file to the repo root. Probably the latter since we link to it elsewhere.
Also suggest either Do we -> Does GitHub, or CodeQL extension by GitHub.
aeisenberg
force-pushed
the
aeisenberg/modal
branch
from
cae375a to
0d63b7e
Compare
adityasharad
approved these changes
Jan 30, 2021
Modal dialogs do not allow for markdown text. The link was invalid. Also, make CodeQL more prominent in the dialog.
aeisenberg
force-pushed
the
aeisenberg/modal
branch
from
0d63b7e to
8b8c55a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal dialogs do not allow for markdown text. Also, make CodeQL more
prominent in the dialog.
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.