Avoid displaying irrelevant error #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/fix-orphaned
branch
from
e8b8457 to
a636900
Compare
adityasharad
approved these changes
Feb 9, 2021
aeisenberg
force-pushed
the
aeisenberg/fix-orphaned
branch
18 times, most recently
from
fa33e2f to
ab28127
Compare
Problem was misplaced parens. We were not waiting for the call to `pathExists` to complete before making the call to `stat` the directory. When the directory does not exist, then `stat` throws an error.
aeisenberg
force-pushed
the
aeisenberg/fix-orphaned
branch
from
ab28127 to
0fe64c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was misplaced parens. We were not waiting for
the call to
pathExiststo complete before making the callto
statthe directory. When the directory does notexist, then
statthrows an error.Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.