Expand disk cache evaluator options #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Mar 11, 2021
| ], | ||
| "default": null, | ||
| "minimum": 1024, | ||
| "description": "Maximum size of the disk cache (in MB). Leave blank to allow the evaluator to automatically adjust the size of the disk cache based on the size of the codebase and the complexity of the queries being executed." |
There was a problem hiding this comment.
Suggested change
| "description": "Maximum size of the disk cache (in MB). Leave blank to allow the evaluator to automatically adjust the size of the disk cache based on the size of the codebase and the complexity of the queries being executed." | |
| "description": "Maximum size of the disk cache (in MB). Leave blank or set to 0 to allow the evaluator to automatically adjust the size of the disk cache based on the size of the codebase and the complexity of the queries being executed." |
There was a problem hiding this comment.
The value can't actually be set to 0 because of the "minimum": 1024
| @@ -123,6 +123,20 @@ | |||
| "maximum": 1024, | |||
| "description": "Number of threads for running queries." | |||
| }, | |||
| "codeQL.runningQueries.saveCache": { | |||
There was a problem hiding this comment.
Probably add a scope of "scope": "window" to ensure that downloaded workspaces don't accidentally blow up someone's hard drive.
Co-authored-by: Andrew Eisenberg <[email protected]>
|
Nice work! The failing integration build is probably just a flaky test. Re-running. |
aeisenberg
approved these changes
Mar 12, 2021
|
@github/docs-content-dsp Do we need to update docs for this? |
👋🏽 Thanks for the ping! This one doesn't need a docs update 😃 (We have a general section about "Configuring settings for running queries", and we can rely on the descriptions in the extension itself for more detail.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #593 by expanding the options that can be passed to control how the evaluator handles the disk cache. In particular, it exposes to the user two settings - the first enables the saving of intermediate results to the cache, and the second allows limiting of the size of the cache. The default behaviour is unchanged from the current options - i.e. intermediate results are not saved to the disk cache, and the evaluator is allowed to choose its own limit on maximum cache size.