Report description for test failure when possible #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Mar 18, 2021
edoardopirovano
force-pushed
the
test-failure-reporting
branch
from
65722f7 to
74006b2
Compare
aeisenberg
approved these changes
Mar 19, 2021
|
Thanks! Do you or should I now close #774? Or are you in general only closing issues once the changes have been released? (@edoardopirovano in case you did not know this yet, you can use certain keywords in the pull request description to make GitHub link pull request and issue automatically.) |
|
This is in the 1.4.4 release so I think it should be okay to close the issue (I don't have the access to do so, though). Ooh, thanks for heads up, I wasn't aware of those keywords. |
|
If in your PR description, you put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #774 by reading the
failureDescriptionfield for a test failure and when this is present reporting this instead of the diff. I believe this is the right choice since as I understand it when this field is present, the diff will not be useful as it means something went more catastrophically wrong (e.g. we couldn't find the expected output).