Add feature to jump to the .ql file referenced by a .qlref #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
reviewed
Mar 29, 2021
edoardopirovano
force-pushed
the
open-qlref
branch
from
b9745d9 to
d07b4ef
Compare
|
Updated to account for the minor CLI changes in the internal PR, which has now been merged. This is now ready for merging, although doing so will mean we should not release a new version of the extension until the new CLI is released. |
aeisenberg
approved these changes
Apr 6, 2021
| helpers.showAndLogErrorMessage( | ||
| 'Jumping from a .qlref file to the .ql file it references is not ' | ||
| + 'supported with the CLI version you are running.\n' | ||
| + 'Please upgrade your CLI to use this feature.'); |
There was a problem hiding this comment.
Would be nice to include the minimum cli version here. Something like:
Suggested change
| + 'Please upgrade your CLI to use this feature.'); | |
| + `Please upgrade your CLI to version ${CLI_VERSION_WITH_RESOLVE_QLREF} or later to use this feature.`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to jump from a
.qlreffile to the.qlfile it references. Note that it should not be merged yet, as it relies on a new CLI callresolve qlrefwhich is not released yet.Closes #654