Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid opening the results panel on db deletion #831

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Apr 14, 2021

Fixes #823

Replace this with a description of the changes your pull request makes.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [n/a] @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@aeisenberg aeisenberg force-pushed the aeisenberg/keep-panel-closed branch from ff6acfd to c5fefa3 Compare April 14, 2021 20:26
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

Comment on lines +177 to +184
// this._panel.onDidChangeViewState(
// (e) => {
// this.logger.log(JSON.stringify(e));
// },
// null,
// ctx.subscriptions
// );

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to check this in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. No. Should be removed.

@aeisenberg aeisenberg merged commit bf5ed19 into main Apr 19, 2021
@aeisenberg aeisenberg deleted the aeisenberg/keep-panel-closed branch April 19, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing database reopens "CodeQL Query Results" panel
2 participants