Forward all query metadata to the queryserver #838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards all the query metadata to the queryserver.
Currently, only
@kind
and@id
are forwarded for most users. This results in metadata errors when running some queries, even if the queries being run had the correct metadata. For example, the@kind metric
query requires either the@tags summary
metadata or the@metricType
metadata key to be defined. However the VS Code extension doesn't currently forward the@tags
and@metricType
properties, so the queryserver reports errors whenever a user tries to run these queries.With this PR, we forward all the query metadata to the queryserver, so queries like these will no longer report metadata errors.
Checklist
@github/docs-content-codeql
has been cc'd in all issues for UI or other user-facing changes made by this pull request.