Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LGTM download messages #852

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Apr 28, 2021

Fixes #813 (commit 6c81212). I've expanded the LGTM download message to prompt users to choose a language:

image

👆🏽 This doesn't apply to all databases, hence "if available". (I hope that's clear enough, but otherwise we can try to only display this message for multi-language databases. I haven't looked at how to do this yet 🙇🏽‍♀️)

(281084e fixes some minor typos.)

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • n/a @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@shati-patel shati-patel marked this pull request as ready for review April 28, 2021 13:50
@shati-patel shati-patel requested a review from aeisenberg April 28, 2021 14:45
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this sounds better?

extensions/ql-vscode/src/databases-ui.ts Outdated Show resolved Hide resolved
extensions/ql-vscode/src/extension.ts Outdated Show resolved Hide resolved
@aeisenberg aeisenberg merged commit b64284c into github:main Apr 29, 2021
@shati-patel shati-patel deleted the lgtm/download branch April 29, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to LGTM download messages
2 participants