-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to language guides for empty query results #866
Conversation
Thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. One more thing that needs to happen before merging. Can you add an entry in the CHANGELOG.md
file? Follow the format of previous entries and add text like this:
Display a helpful message and link to documentation when a query produces no results.
It would also be nice to style this better, with bigger text and margins. But that's something to work on later.
Once you get the changelog updated, we can merge this.
Thanks! I would love to pick up the backlog that addresses the styling and maybe a dynamic link to the docs depending on the language. Please let me know if it's okay for me to create an issue for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
That would be great. Please create an issue. First, can you look at styling and then we can think of a better link to include. There might be something more useful than going to the language guide. |
Empty table when no query results are returned is replaced by a message with documentation to the CodeQL Language Guides.
Fixes #551.
Please let me know if this warrants a change to the changelogs and if I should cc
@github/docs-content-codeql
.Checklist
@github/docs-content-codeql
has been cc'd in all issues for UI or other user-facing changes made by this pull request.