Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filename pattern in history view #930

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

bmuskalla
Copy link

@bmuskalla bmuskalla commented Aug 19, 2021

Allow users to see the filename in the query history view instead of the name from the metadata. Introduce the %f pattern in the history view, supporting full queries as well as quick eval queries.

Screenshot 2021-08-19 at 12 38 59

Reformatted the description of the format preference to better see the available patterns.
Screenshot 2021-08-19 at 12 40 43

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@bmuskalla bmuskalla requested a review from a team as a code owner August 19, 2021 10:41
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Looks like you pulled back in an old changelog entry but once that's fixed I think this is good to go.

extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
@bmuskalla
Copy link
Author

Thanks @edoardopirovano for the feedback, fixed the changelog

@edoardopirovano edoardopirovano enabled auto-merge (rebase) August 19, 2021 12:01
@edoardopirovano edoardopirovano merged commit 089b23f into github:main Aug 19, 2021
@aeisenberg
Copy link
Contributor

Nice. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants