Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version copy for missing cli #958

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Fix version copy for missing cli #958

merged 3 commits into from
Oct 1, 2021

Conversation

mgsium
Copy link
Contributor

@mgsium mgsium commented Oct 1, 2021 •
edited
Loading

Fixes #902

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.

@mgsium mgsium requested a review from a team as a code owner October 1, 2021 11:37
shati-patel
shati-patel reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, first PR 😎

This looks good! Could I get someone else on @github/codeql-vscode-reviewers to review/approve, since we paired on this 🙂

edoardopirovano
edoardopirovano approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@edoardopirovano edoardopirovano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion rephrasing the change note, otherwise LGTM.

extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
@edoardopirovano
Copy link
Contributor

And congrats on your first PR! 🎉

aeisenberg
aeisenberg approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@shati-patel shati-patel merged commit 0493e31 into github:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel left review comments

@edoardopirovano edoardopirovano edoardopirovano approved these changes

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copying version information does not work without CodeQL CLI
4 participants
@mgsium @edoardopirovano @aeisenberg @shati-patel