Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete database after removing it from query server control. #959

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Delete database after removing it from query server control. #959

merged 3 commits into from
Oct 7, 2021

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Oct 1, 2021

We need to remove it from the query server before deleting the files it otherwise the query server may access it prior to deletion.

@alexet alexet requested a review from aeisenberg October 1, 2021 17:43
@alexet alexet requested a review from a team as a code owner October 1, 2021 17:43
aeisenberg
aeisenberg approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This makes sense.

Can you also add a changelog entry?

@aeisenberg aeisenberg requested a review from shati-patel October 7, 2021 15:15
@aeisenberg aeisenberg removed the request for review from shati-patel October 7, 2021 15:18
@aeisenberg aeisenberg enabled auto-merge October 7, 2021 15:18
@aeisenberg aeisenberg merged commit 197ab99 into github:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexet @aeisenberg