Handle nonprint chars #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add progress messages to LGTM download option. (github#960)
aeisenberg
reviewed
Oct 6, 2021
Comment on lines
13
to
17
| const codes: { [key: string]: any } = { | ||
| '\n': 'U+000A', | ||
| '\b': 'U+2084', | ||
| '\0': 'U+0000' | ||
| }; |
There was a problem hiding this comment.
Can you move this out of the function to the module level scope? This way, the constant doesn't need to be recreated on each invocation.
There was a problem hiding this comment.
And presumably, you will be able to add more replacements in the future?
There was a problem hiding this comment.
You can explicitly add all of the control char mappings described here #584 (comment).
| if ( | ||
| typeof v === 'string' | ||
| || typeof v === 'number' | ||
| || typeof v === 'boolean' | ||
| ) { | ||
| return <span>{v.toString()}</span>; | ||
| const text = v.toString(); |
There was a problem hiding this comment.
Not a big fan of one char variable names. Can you rename it to something like rawValue. I know this code was already, but it's never too late to make improvements. :)
Comment on lines
27
to
31
| for (const char in codes) { | ||
| if (char === newVal[i]) { | ||
| newVal[i] = codes[char]; | ||
| } | ||
| } |
There was a problem hiding this comment.
There's something simpler you can do here. You don't need to loop.
Suggested change
| for (const char in codes) { | |
| if (char === newVal[i]) { | |
| newVal[i] = codes[char]; | |
| } | |
| } | |
| newVal[i] = codes[newVal[i]] || newVal[i]; |
aeisenberg
reviewed
Oct 8, 2021
Co-authored-by: Andrew Eisenberg <[email protected]>
aeisenberg
approved these changes
Oct 8, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #584
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.