-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.com.de support added to all.two.level.subdomain.ts #532
base: main
Are you sure you want to change the base?
Conversation
@funnymomo is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request introduces a minor update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libraries/helpers/src/subdomain/all.two.level.subdomain.ts (1)
2-2
: Maintain alphabetical order for better maintainability.The addition of ".com.de" is correct, but it should be moved to maintain alphabetical order with the other entries.
Apply this diff to reposition the entry:
export const allTwoLevelSubdomain = [ - ".com.de", ".net.ac", ".gov.ac", ".org.ac", ".mil.ac", ".co.ae", + ".com.de", ".net.ae",
What kind of change does this PR introduce?
#520
Why was this change needed?
#520
Checklist:
Put a "X" in the boxes below to indicate you have followed the checklist;
Summary by CodeRabbit