refactor: signal handling to improve clarity and correctness #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed interruptSignalsCount to maxInterruptSignals for better readability. - Fixed the loop condition to correctly iterate from 0 to maxInterruptSignals.
pd93
reviewed
Dec 31, 2024
| signal.Notify(ch, os.Interrupt, syscall.SIGTERM) | ||
|
|
||
| go func() { | ||
| for i := range interruptSignalsCount { | ||
| for i := 0; i < maxInterruptSignals; i++ { |
There was a problem hiding this comment.
These loops are functionally the same and I personally prefer the newer for i := range maxInterruptSignals syntax.
No objection to the renaming.
vmaerten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming: The constant interruptSignalsCount has been renamed to maxInterruptSignals to better reflect its purpose, which is to define the maximum number of interrupt signals that can be handled.
Loop Fix: The loop condition has been corrected to iterate from 0 to maxInterruptSignals, ensuring that the loop runs the expected number of times.