-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google/externalaccount/filecredsource.go): improve error message in subjectToken function to include the actual error detail #749
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 0f0ed90) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621836. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621836. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/621836. |
Message from Tiger Kaovilai: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/621836. |
subjectToken function now return error messages when failing to open file credentials. This will allow distinguishing between file not found and other errors.
This PR (HEAD: e72b1dc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621836. Important tips:
|
This PR (HEAD: b18f18a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621836. Important tips:
|
It was unclear to me why credentials file couldn't open. This should clear up from user log if file is missing, or otherwise.