-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling error on getting project id from google metadata server #752
base: master
Are you sure you want to change the base?
Handling error on getting project id from google metadata server #752
Conversation
This PR (HEAD: 679e492) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/626138. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626138. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/626138. |
679e492
to
2dd34a4
Compare
This PR (HEAD: 2dd34a4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/626138. Important tips:
|
Message from r o: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626138. |
Adding error handling. I found adding test is difficult, if any good way please point.
Fix #751