Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tests #3110

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Windows tests #3110

merged 1 commit into from
Apr 10, 2024

Conversation

roblarsen
Copy link
Member

No description provided.

@roblarsen roblarsen self-assigned this Apr 9, 2024
@roblarsen
Copy link
Member Author

roblarsen commented Apr 9, 2024

closes #3109

This is correct behavior. One test is failing and the other is canceled. Once one of the two tests in the runner fails, the other one is immediately canceled ("fail fast")

I still don't know why this test is failing, but we have an automated test for it, so it will never happen again.

@roblarsen roblarsen requested a review from coliff April 9, 2024 15:05
@coliff
Copy link
Member

coliff commented Apr 9, 2024

I'm on Node v18.19.1 on Windows 11 Pro.

npm run test is failing:
image

looks like it's related to the / path ?

@roblarsen
Copy link
Member Author

Failing tests is intentional right now

@roblarsen
Copy link
Member Author

I'm on Node v18.19.1 on Windows 11 Pro.

looks like it's related to the / path ?

Yeah, something changed at some point. It's failing because "" is not "/"

v8.0.0 the test worked. I'm going to step through versions of the testing framework to see where it broke.

@roblarsen
Copy link
Member Author

And... the tests should be fixed. tl;dr; node-glob breaking change that I missed being a Codespaces addict

* Updates for gulp 5

* .DS_Store ignored from copy operations
@coliff
Copy link
Member

coliff commented Apr 10, 2024

yay! nice one @roblarsen !

image

@coliff coliff added the github_actions Pull requests that update Github_actions code label Apr 10, 2024
@roblarsen roblarsen merged commit 72a8f61 into main Apr 10, 2024
9 checks passed
@roblarsen roblarsen deleted the windows-tests branch April 10, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants